-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs for Proto package manager #6978
base: main
Are you sure you want to change the base?
Conversation
This commit adds support for the Proto package manager in the site/types/release.ts, site/util/downloadUtils.ts, components/Downloads/Release/PlatformDropdown.tsx, and components/Icons/Platform/Proto.tsx files. The Proto package manager is now included as an option in the PackageManager enum and the platformItems array. The PlatformDropdown component has been updated to display the Proto icon. Additionally, the en.json file has been updated to include instructions for installing Proto.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
#7037 will supersede this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, unfortunately, we are not accepting changes to the current Downloads page Codebox component. Read more here: #7037
Could you remove those changes from this PR? Thanks 🙏 (The i18n translation change is fine tho)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with that @ovflowd said, I feel that this PR changes several different parts of the code. IMHO, each part should be split into a different PR, or at least a different commit (w/ drebase), to make understanding the file history easier.
Also, there hasn't been any activity from the author in a little bit. If there's no activity in the next week (~4 months since open), I'm going to assume this stale-d and close it. |
Description
This commit adds support for the Proto package manager in the site/types/release.ts, site/util/downloadUtils.ts, components/Downloads/Release/PlatformDropdown.tsx, and components/Icons/Platform/Proto.tsx files. The Proto package manager is now included as an option in the PackageManager enum and the platformItems array. The PlatformDropdown component has been updated to display the Proto icon. Additionally, the en.json file has been updated to include instructions for installing Proto.
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.