Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List WinGet as install method for Windows #6953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cinderblock
Copy link

Description

This change adds winget to the list of ways to install Node.js on Windows.

Validation

A new entry on https://nodejs.org/en/download/package-manager

Related Issues

#4028 - regression
#3993

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

npm install fails on my Windows machine. Cannot run any test commands.

@cinderblock cinderblock requested a review from a team as a code owner July 31, 2024 00:51
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 31, 2024 6:14pm

@ovflowd
Copy link
Member

ovflowd commented Jul 31, 2024

Sorry, I don't think this will land; For context, we're halting any additions or changes to the CodeBoxes as we redesign the Package Managers page, splitting it into a Node version managers page and an OS package manager page.

I don't speak for the website team, but I don't think this would land, at least now, since we are still in a scoping phase of how we will restructure this page.

I appreciate the effort you've put in here. I'll let other website team members also comment on this :)

@cinderblock
Copy link
Author

@ovflowd That makes sense. Thank you for the detail.

I hope WinGet gets noted more prominently. It's the easiest and fastest way to install Node on modern Windows systems. No extra dependencies and is easy to update everything: winget upgrade --all

@cinderblock cinderblock changed the title List winget as install method for Windows List WinGet as install method for Windows Jul 31, 2024
@ovflowd
Copy link
Member

ovflowd commented Jul 31, 2024

@ovflowd That makes sense. Thank you for the detail.

I hope WinGet gets noted more prominently. It's the easiest and fastest way to install Node on modern Windows systems. No extra dependencies and is easy to update everything: winget upgrade --all

Winget is already listed here: https://nodejs.org/en/download/package-manager/all#windows-1

@cinderblock
Copy link
Author

I saw that in the source code but wasn't sure how to even get to the ./all url from the normal page.

In any case, glad y'all are on it!

@cinderblock
Copy link
Author

Friendly bump. Any progress on the Package Managers page updates? Is there a milestone/branch we can track?

@ovflowd
Copy link
Member

ovflowd commented Sep 10, 2024

Friendly bump. Any progress on the Package Managers page updates? Is there a milestone/branch we can track?

Hey there! Unfortunately not. I realized I forgot to open the issue here, I was low bandwidth and asked for colleagues to open one (https://openjs-foundation.slack.com/archives/C044DNU6TEH/p1724524239630829)

Let me open an issue to keep track of the work :)

@ovflowd
Copy link
Member

ovflowd commented Sep 12, 2024

I've opened an issue: #7037, finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants