-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
src: add more checks and clarify docs for external references #61719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help catch unregistered bindings.
Collaborator
|
Review requested:
|
addaleax
approved these changes
Feb 7, 2026
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61719 +/- ##
==========================================
- Coverage 89.74% 89.71% -0.03%
==========================================
Files 674 675 +1
Lines 204348 204529 +181
Branches 39271 39309 +38
==========================================
+ Hits 183396 183503 +107
- Misses 13262 13295 +33
- Partials 7690 7731 +41
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Feb 7, 2026
jasnell
approved these changes
Feb 8, 2026
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61719 ✔ Done loading data for nodejs/node/pull/61719 ----------------------------------- PR info ------------------------------------ Title src: add more checks and clarify docs for external references (#61719) Author Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung) Branch joyeecheung:extern-check -> nodejs:main Labels c++, author ready, needs-ci Commits 1 - src: add more checks and clarify docs for external references Committers 1 - Joyee Cheung <joyeec9h3@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61719 Refs: https://github.com/nodejs/node/pull/61718 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61719 Refs: https://github.com/nodejs/node/pull/61718 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 07 Feb 2026 14:02:28 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61719#pullrequestreview-3767150689 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61719#pullrequestreview-3768422982 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/61719#pullrequestreview-3768692721 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-02-08T14:00:26Z: https://ci.nodejs.org/job/node-test-pull-request/71249/ - Querying data for job/node-test-pull-request/71249/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61719 From https://github.com/nodejs/node * branch refs/pull/61719/merge -> FETCH_HEAD ✔ Fetched commits as d0e75fd65b19..f4efb5f69f49 -------------------------------------------------------------------------------- [main bae3ad12cd] src: add more checks and clarify docs for external references Author: Joyee Cheung <joyeec9h3@gmail.com> Date: Sat Feb 7 15:00:29 2026 +0100 2 files changed, 68 insertions(+), 3 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- src: add more checks and clarify docs for external references
Temporary files removed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help catch unregistered bindings.
Refs: #61718