Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Feb 7, 2026

To help catch unregistered bindings.
Refs: #61718

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 7, 2026
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 7, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2026
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.71%. Comparing base (8e41b8d) to head (f4efb5f).
⚠️ Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/node_snapshotable.cc 48.14% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61719      +/-   ##
==========================================
- Coverage   89.74%   89.71%   -0.03%     
==========================================
  Files         674      675       +1     
  Lines      204348   204529     +181     
  Branches    39271    39309      +38     
==========================================
+ Hits       183396   183503     +107     
- Misses      13262    13295      +33     
- Partials     7690     7731      +41     
Files with missing lines Coverage Δ
src/node_snapshotable.cc 72.94% <48.14%> (-0.71%) ⬇️

... and 58 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2026
@nodejs-github-bot nodejs-github-bot merged commit 2c8517e into nodejs:main Feb 9, 2026
79 of 81 checks passed
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 9, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61719
✔  Done loading data for nodejs/node/pull/61719
----------------------------------- PR info ------------------------------------
Title      src: add more checks and clarify docs for external references (#61719)
Author     Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung)
Branch     joyeecheung:extern-check -> nodejs:main
Labels     c++, author ready, needs-ci
Commits    1
 - src: add more checks and clarify docs for external references
Committers 1
 - Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61719
Refs: https://github.com/nodejs/node/pull/61718
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61719
Refs: https://github.com/nodejs/node/pull/61718
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 07 Feb 2026 14:02:28 GMT
   ✔  Approvals: 3
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61719#pullrequestreview-3767150689
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61719#pullrequestreview-3768422982
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/61719#pullrequestreview-3768692721
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-02-08T14:00:26Z: https://ci.nodejs.org/job/node-test-pull-request/71249/
- Querying data for job/node-test-pull-request/71249/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 61719
From https://github.com/nodejs/node
 * branch                  refs/pull/61719/merge -> FETCH_HEAD
✔  Fetched commits as d0e75fd65b19..f4efb5f69f49
--------------------------------------------------------------------------------
[main bae3ad12cd] src: add more checks and clarify docs for external references
 Author: Joyee Cheung <joyeec9h3@gmail.com>
 Date: Sat Feb 7 15:00:29 2026 +0100
 2 files changed, 68 insertions(+), 3 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
src: add more checks and clarify docs for external references

To help catch unregistered bindings.

PR-URL: #61719
Refs: #61718
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

[main 25a87b5195] src: add more checks and clarify docs for external references
Author: Joyee Cheung <joyeec9h3@gmail.com>
Date: Sat Feb 7 15:00:29 2026 +0100
2 files changed, 68 insertions(+), 3 deletions(-)
✔ 25a87b51955ce362be154ab6d237e9f46a726bf1
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

The following commits are ready to be pushed to origin/main

  • 25a87b5195 src: add more checks and clarify docs for external references

Temporary files removed.
To finish landing:

  1. Run:
    git push origin main
  2. Post "Landed in 25a87b51955c" in src: add more checks and clarify docs for external references #61719
    gh pr comment src: add more checks and clarify docs for external references #61719 --body "Landed in 25a87b51955c"
    gh pr close src: add more checks and clarify docs for external references #61719
https://github.com/nodejs/node/actions/runs/21832712344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants