Skip to content

test: simplify test-cli-node-options-docs #61006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: simplify test-cli-node-options-docs #61006

aduh95 wants to merge 1 commit into from
+19 −43

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 9, 2025

The current version is hard to reason about with non-const variables, and use of === false. Also we need a change for #60906 to correctly detect HAVE_SQLITE in the code.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (0ffa607) to head (888ab08).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61006      +/-   ##
==========================================
- Coverage   92.23%   88.53%   -3.71%     
==========================================
  Files         343      703     +360     
  Lines      139073   208432   +69359     
  Branches    22251    40195   +17944     
==========================================
+ Hits       128277   184534   +56257     
- Misses      10569    15905    +5336     
- Partials      227     7993    +7766

see 481 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70457/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2025
@aduh95 aduh95 mentioned this pull request Dec 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ErickWendel ErickWendel ErickWendel approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @lpinca @cjihrig @ErickWendel