lib,test: enforce use of assert.fail via a lint rule

[aduh95]

assert.fail communicates the intent better than assert(false) IMO

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (0ffa607) to head (2cdc4a5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61004      +/-   ##
==========================================
- Coverage   92.23%   88.52%   -3.72%     
==========================================
  Files         343      703     +360     
  Lines      139073   208432   +69359     
  Branches    22251    40204   +17953     
==========================================
+ Hits       128277   184518   +56241     
- Misses      10569    15938    +5369     
- Partials      227     7976    +7749     

Files with missing lines	Coverage Δ
lib/internal/crypto/cipher.js	97.94% <100.00%> (ø)

... and 480 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70448/

[Renegade334]

This pattern has actually made its way into lib as well (

node/lib/internal/crypto/cipher.js

Line 100 in 83ba6b1

assert(false, 'Cannot change encoding');

) – would it be better just to have it as a global rule?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70460/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70462/