Skip to content

esm: avoid throw when module specifier is not url #61000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CraigMacomber wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

esm: avoid throw when module specifier is not url #61000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ded5e5
esm: avoid throw when module specifier is not url
CraigMacomber Dec 9, 2025
95c0855
Update lib/internal/modules/esm/resolve.js
CraigMacomber Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const {
ERR_INVALID_MODULE_SPECIFIER,
ERR_INVALID_PACKAGE_CONFIG,
ERR_INVALID_PACKAGE_TARGET,
ERR_INVALID_URL,
ERR_MODULE_NOT_FOUND,
ERR_PACKAGE_IMPORT_NOT_DEFINED,
ERR_PACKAGE_PATH_NOT_EXPORTED,
Expand Down Expand Up @@ -846,12 +847,13 @@ function moduleResolve(specifier, base, conditions, preserveSymlinks) {
} else if (protocol === 'file:' && specifier[0] === '#') {
resolved = packageImportsResolve(specifier, base, conditions);
} else {
try {
resolved = new URL(specifier);
} catch (cause) {
const url = URL.parse(specifier);
if (url !== null) {
resolved = url;
} else {
if (isData && !BuiltinModule.canBeRequiredWithoutScheme(specifier)) {
const error = new ERR_UNSUPPORTED_RESOLVE_REQUEST(specifier, base);
setOwnProperty(error, 'cause', cause);
setOwnProperty(error, 'cause', new ERR_INVALID_URL(specifier));
throw error;
}
resolved = packageResolve(specifier, base, conditions);
Expand Down
Loading