Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add esm example for zlib #55946

Merged
merged 1 commit into from
Nov 23, 2024
Merged

doc: add esm example for zlib #55946

merged 1 commit into from
Nov 23, 2024
+230 −13

Conversation

peixotoleonardo
Copy link
Contributor

This PR add esm example for zlib module

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Nov 21, 2024
aduh95
aduh95 reviewed Nov 21, 2024
View reviewed changes
doc/api/zlib.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Nov 21, 2024
View reviewed changes
doc/api/zlib.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Nov 21, 2024
View reviewed changes
doc/api/zlib.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Nov 21, 2024
View reviewed changes
doc/api/zlib.md Outdated Show resolved Hide resolved
@peixotoleonardo
Copy link
Contributor Author

peixotoleonardo commented Nov 22, 2024 •
edited
Loading

@aduh95

What the best way to add your review tips in my PR, with a new commit, or I can use the amend?

@aduh95
Copy link
Contributor

aduh95 commented Nov 22, 2024

What the best way to add your review tips in my PR, with a new commit, or I can use the amend?

Whatever works best for you, all the commits will be squashed upon landing in any case

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2024
lpinca
lpinca approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6190bbc into nodejs:main Nov 23, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6190bbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peixotoleonardo @aduh95 @nodejs-github-bot @lpinca