Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix Node.js 23 column in CHANGELOG.md #55935

Merged
merged 1 commit into from
Nov 22, 2024
Merged

doc: fix Node.js 23 column in CHANGELOG.md #55935

merged 1 commit into from
Nov 22, 2024

Conversation

richardlau
Copy link
Member

The column for Node.js 23 in CHANGELOG.md is missing an opening <td> tag so was not correctly rendering.

  • Before
    image

  • After
    image

@richardlau richardlau added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch. labels Nov 20, 2024
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 20, 2024
@richardlau
Copy link
Member Author

FWIW this affects v23.x but @RafaelGSS I do not think this is worth holding up #55921 for (i.e. this can land separately for the next 23.x release).

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2024
LiviaMedeiros
LiviaMedeiros reviewed Nov 21, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@richardlau
doc: fix Node.js 23 column in CHANGELOG.md
f386574 
The column for Node.js 23 in `CHANGELOG.md` is missing an opening
`<td>` tag so was not correctly rendering.
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 05b3fcb into nodejs:main Nov 22, 2024
13 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 05b3fcb

@richardlau richardlau deleted the changelog branch November 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@jazelly jazelly jazelly approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. meta Issues and PRs related to the general management of the project. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@richardlau @nodejs-github-bot @lpinca @anonrig @aduh95 @RafaelGSS @jazelly @marco-ippolito @LiviaMedeiros