Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node_http2.cc): remove duplicate codeblock #55915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AVVS
Copy link

@AVVS AVVS commented Nov 19, 2024

Original bug was introduced in here: https://github.com/nodejs/node/pull/55155/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771cL1303-R1313
Doesn't seem like that it actually leads to any problems, except extra memcpy

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Nov 19, 2024
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2024
@anonrig anonrig requested a review from jasnell November 19, 2024 04:53
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2024
@nodejs-github-bot
Copy link
Collaborator

@anonrig
Copy link
Member

anonrig commented Nov 19, 2024

@AVVS you need to update your commit message according to the requirements

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (1d01ad6) to head (6cefd81).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55915      +/-   ##
==========================================
- Coverage   88.01%   88.00%   -0.01%     
==========================================
  Files         653      653              
  Lines      187735   187731       -4     
  Branches    35874    35870       -4     
==========================================
- Hits       165229   165220       -9     
- Misses      15693    15696       +3     
- Partials     6813     6815       +2     
Files with missing lines Coverage Δ
src/node_http2.cc 84.83% <ø> (+0.11%) ⬆️

... and 26 files with indirect coverage changes

---- 🚨 Try these New Features:

@AVVS
Copy link
Author

AVVS commented Nov 19, 2024

updated commit message

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants