-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node_http2.cc): remove duplicate codeblock #55915
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@AVVS you need to update your commit message according to the requirements |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55915 +/- ##
==========================================
- Coverage 88.01% 88.00% -0.01%
==========================================
Files 653 653
Lines 187735 187731 -4
Branches 35874 35870 -4
==========================================
- Hits 165229 165220 -9
- Misses 15693 15696 +3
- Partials 6813 6815 +2
|
updated commit message |
Original bug was introduced in here: https://github.com/nodejs/node/pull/55155/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771cL1303-R1313
Doesn't seem like that it actually leads to any problems, except extra memcpy