build: allow unbundling of Node.js dependencies #55903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
the
embedding
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Nov 18, 2024
3 tasks
selfisekai
reviewed
Nov 20, 2024
| @@ -179,7 +178,17 @@ template("node_gn_build") { | |||
| configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] | |||
| configs += [ "//build/config/gcc:symbol_visibility_default" ] | |||
| } | |||
|
|
|||
| if (use_system_llhttp) { | |||
| libs += [ "llhttp" ] | |||
There was a problem hiding this comment.
This passes -lllhttp to the linker, but does not add its header location to include_dirs - pkg-config can resolve it under the name libllhttp
Comment on lines
+187
to
+188
| libs += [ "hdr_histogram" ] | ||
| include_dirs += [ "/usr/include/hdr" ] |
There was a problem hiding this comment.
This also should be pkg_config on hdr_histogram
Comment on lines
153
to
155
| "deps/brotli", | ||
| "deps/cares", | ||
| "deps/histogram", |
There was a problem hiding this comment.
Suggested change
| "deps/brotli", | |
| "deps/cares", | |
| "deps/histogram", |
histogram gets added below if !use_system_histogram, for brotli and cares the newly created targets should be added instead if unbundling (currently they don't get used for anything)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs electron/electron#44691
Linux distributions have guidelines on using distro-provided dependencies, rather than compiling them in statically - Electron already did this via electron/electron#34841 until we ingested Node.js' GN support, which didn't contain this.
This PR this enables downstream packagers to unbundle these dependencies. We don't need to do this for zlib, as the existing gn workflow uses the same
//third_party/zlib, so unbundling zlib with Chromium tools in//build/linux/unbundleworks already. This adds support for some of the others.