fix: Adjusting ERR_FS_FILE_TOO_LARGE description for I/O Limit #55899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
kevinuehara
force-pushed
the
kevinuehara/fix-file-to-large-error-description
branch
from
5856e13
to
07dfb64
Compare
|
/cc @nodejs/fs |
|
I think the proper fix for #55864 is handling multiple calls internally for files greater than 2 GB as suggested here |
smoores-dev
reviewed
Nov 21, 2024
| @@ -1358,7 +1358,7 @@ Path is a directory. | |||
| ### `ERR_FS_FILE_TOO_LARGE` | |||
|
|
|||
| An attempt has been made to read a file whose size is larger than the maximum | |||
| allowed size for a `Buffer`. | |||
| limit for an I/O operation. | |||
There was a problem hiding this comment.
Is it worth doing any of:
- Noting that this limit is 2GB
- Noting that this is due to a libuv decision/implementation detail
- Linking to the related libuv PR
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm fixing the ERR_FS_FILE_TOO_LARGE description.
Before the error was "An attempt has been made to read a file whose size is larger than the maximum
allowed size for a Buffer", but actually the Buffer should be I/O Limit.
This PR fixes the issue 55864 and 42497
cc: @RedYetiDev @ErickWendel @marco-ippolito