test: use test runner in eventtarget-once-twice test #55752
Conversation
Signed-off-by: Alexander “weej” Jones <[email protected]>
nodejs-github-bot
added
needs-ci
pmarchini
added
the
code-and-learn
…ease the linter...
| await once(et, 'foo'); | ||
| await once(et, 'foo'); | ||
| })().then(common.mustCall()); | ||
| test('should resolve `once` twice', (t, done) => { |
There was a problem hiding this comment.
This can be simplified as an asynchronous function, right? Calling "done" in the middle might lead to a race condition that generates extraneous asynchronous activity
There was a problem hiding this comment.
That was my original idea but @tlhunter suggested we try with just done. Personally I'm 65/35 on doing it with async the way it currently is now. What do you both think?
There was a problem hiding this comment.
(Now, after I updated the PR to use async (again), albeit slightly simpler)
There was a problem hiding this comment.
I'm inclined on the async way, it's much cleaner, and there's IMO less of a chance for a race condition
RedYetiDev
added
the
commit-queue-squash
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55752 +/- ##
==========================================
+ Coverage 88.40% 88.42% +0.01%
==========================================
Files 654 654
Lines 187747 187752 +5
Branches 36127 36129 +2
==========================================
+ Hits 165972 166012 +40
+ Misses 15009 14992 -17
+ Partials 6766 6748 -18 |
|
hey @alexweej, there's a lint issue: |
Signed-off-by: Alexander “weej” Jones [email protected]