Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump tar from 6.x to 7.x, selectively import required functions #533

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Jul 16, 2024

Changes from #532 made it possible to update tar from 6.x to 7.x and use new package.json exports that are included in 7.x, allowing us to further reduce corepack bundle size.

Before update:

dist\lib\corepack.cjs 927.6kb

After update to tar@7:

dist\lib\corepack.cjs 932.8kb

After update to tar@7 + selective imports:

dist\lib\corepack.cjs 924.0kb

@merceyz merceyz marked this pull request as draft July 16, 2024 22:55
@merceyz
Copy link
Member

merceyz commented Jul 16, 2024

Making this a draft since it depends on #532 landing first.

@wojtekmaj wojtekmaj marked this pull request as ready for review July 17, 2024 13:12
…nctions

Changes from #532 made it possible to update tar from 6.x to 7.x and use new package.json exports that are included in 7.x, allowing us to further reduce corepack bundle size.

Before update:

  dist\lib\corepack.cjs  927.6kb

After update to tar@7:

  dist\lib\corepack.cjs  932.8kb

After update to tar@7 + selective imports:

  dist\lib\corepack.cjs  924.0kb
@wojtekmaj
Copy link
Contributor Author

Un-drafting as #532 has landed :)

@aduh95 aduh95 merged commit 67463b2 into nodejs:main Jul 18, 2024
13 checks passed
@wojtekmaj wojtekmaj deleted the tar-7 branch July 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants