Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump esbuild from 0.19.x to 0.21.x #517

Merged
merged 2 commits into from
Jul 12, 2024
Merged

chore: bump esbuild from 0.19.x to 0.21.x #517

merged 2 commits into from
Jul 12, 2024

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Jul 11, 2024

Why bump from 0.19.x:
Plenty of bug fixes and performance improvements

Why bump to 0.21.x and not 0.23.x:
tsx, which I propose in #518, uses 0.21.x (at the moment of writing), so this will avoid duplicated dependencies. It's also easier to handle, and potentially roll back, major version bumps that were split into stages.

Why bump from 0.19.x:
Plenty of bug fixes and performance improvements

Why bump to 0.21.x and not 0.23.x:
tsx, which I plan to propose soon, uses 0.21.x, so this will avoid duplicated dependencies.
@merceyz
Copy link
Member

merceyz commented Jul 11, 2024

tsx, which I plan to propose soon, uses 0.21.x, so this will avoid duplicated dependencies

You can use packageExtensions to change that to a peer dependency to avoid duplicates.

@wojtekmaj
Copy link
Contributor Author

wojtekmaj commented Jul 11, 2024

tsx is well-maintained. They are currently discussing a bump to 0.22.x: privatenumber/tsx#606. I don't believe there's an urgent need to override secondary dependencies tsx has been tested with. Especially when the change was done with intention of improving reliability :D

@aduh95 aduh95 enabled auto-merge (squash) July 12, 2024 08:52
@aduh95 aduh95 merged commit c01af88 into nodejs:main Jul 12, 2024
10 checks passed
@wojtekmaj wojtekmaj deleted the esbuild-0.21 branch July 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants