Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace rm -rf with node -e for cross-platform file deletion #501

Merged
merged 6 commits into from
Jun 13, 2024
Merged

chore: replace rm -rf with node -e for cross-platform file deletion #501

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b2c279
chore: ignore yarn cache
leewakin Jun 13, 2024
5b8e527
chore: replace rm -rf with rimraf
leewakin Jun 13, 2024
82f3c5c
Revert "chore: ignore yarn cache"
liwakin Jun 13, 2024
281b004
Revert "chore: replace rm -rf with rimraf"
liwakin Jun 13, 2024
71a61cd
replace 'rm -rf' with 'node -e'
liwakin Jun 13, 2024
e4c382e
chore: fix inconsistency in rimraf script spacing
liwakin Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,14 @@
"undici-types": "6.x"
},
"scripts": {
"build": "rm -rf dist shims && run build:bundle && ts-node ./mkshims.ts",
"build": "run clean && run build:bundle && ts-node ./mkshims.ts",
"build:bundle": "esbuild ./sources/_lib.ts --bundle --platform=node --target=node18.17.0 --external:corepack --outfile='./dist/lib/corepack.cjs' --resolve-extensions='.ts,.mjs,.js'",
"clean": "run rimraf dist shims",
"corepack": "ts-node ./sources/_cli.ts",
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
"lint": "eslint .",
"prepack": "yarn build",
"postpack": "rm -rf dist shims",
"postpack": "run clean",
"rimraf": "node -e 'for(let i=2;i<process.argv.length;i++)fs.rmSync(process.argv[i],{recursive:true,force:true});'",
Copy link
Member

@styfle styfle Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rimraf": "node -e 'for(let i=2;i<process.argv.length;i++)fs.rmSync(process.argv[i],{recursive:true,force:true});'",
"rimraf": "node -e 'for(let arg of process.argv.slice(2))fs.rmSync(arg,{recursive:true,force:true})'",

slightly shorter

"typecheck": "tsc --noEmit",
"test": "jest"
},
Expand Down