Corepack "EACCES": Clearer Errors #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Dec 29, 2023
aduh95
reviewed
Dec 29, 2023
aduh95
reviewed
Dec 29, 2023
sources/folderUtils.ts
Outdated
| @@ -52,6 +53,8 @@ export function getTemporaryFolder(target: string = tmpdir()) { | |||
| } catch (error) { | |||
| if ((error as NodeError).code === `EEXIST`) { | |||
| continue; | |||
| } else if ((error as NodeError).code === `EACCES`) { | |||
| throw new UsageError(`Failed to create cache directory. Please ensure the user has write access to the target directory (${target}). If the user's home directory does not exist, create it first.`, {cause: error}); | |||
There was a problem hiding this comment.
@arcanis it would maybe make sense to add support for this in Clipanion, no?
There was a problem hiding this comment.
Suggested change
| throw new UsageError(`Failed to create cache directory. Please ensure the user has write access to the target directory (${target}). If the user's home directory does not exist, create it first.`, {cause: error}); | |
| // @ts-expect-error UsageError expects one argument | |
| throw new UsageError(`Failed to create cache directory. Please ensure the user has write access to the target directory (${target}). If the user's home directory does not exist, create it first.`, {cause: error}); |
There was a problem hiding this comment.
For now should we remove the cause: error?
|
There are still lint errors to address. |
aduh95
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#329
Targeted Error Handling: Code distinguishes between EEXIST (not relevant) and EACCES (triggers the specific error message), while other errors are still thrown for debugging.
Implementation: Changes are made in the getTemporaryFolder function within node_modules/corepack/dist/lib/corepack.cjs.
Testing: not done.