fix: replace npm registry domain in tarball URL (#502)

nodejs · Jul 12, 2024 · db6fae5 · db6fae5
1 parent 56de2ed
commit db6fae5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/sources/corepackUtils.ts b/sources/corepackUtils.ts
@@ -230,12 +230,11 @@ export async function installVersion(installTarget: string, locator: Locator, {s
         if (registry.bin) {
           binPath = registry.bin;
         }
-      } else {
-        url = url.replace(
-          npmRegistryUtils.DEFAULT_NPM_REGISTRY_URL,
-          () => process.env.COREPACK_NPM_REGISTRY!,
-        );
       }
+      url = url.replace(
+        npmRegistryUtils.DEFAULT_NPM_REGISTRY_URL,
+        () => process.env.COREPACK_NPM_REGISTRY!,
+      );
     }
   } else {
     url = decodeURIComponent(version);

diff --git a/tests/_registryServer.mjs b/tests/_registryServer.mjs
@@ -104,7 +104,7 @@ function generateVersionMetadata(packageName, version) {
       shasum,
       size: mockPackageTarGz.length,
       noattachment: false,
-      tarball: `${process.env.COREPACK_NPM_REGISTRY}/${packageName}/-/${packageName}-${version}.tgz`,
+      tarball: `https://registry.npmjs.org/${packageName}/-/${packageName}-${version}.tgz`,
       ...generateSignature(packageName, version),
     },
   };