feat: parallelize linking, unlinking and installing

An extended version of #500.
nodejs · Jul 11, 2024 · ccf56e9 · ccf56e9
1 parent 22c58fc
commit ccf56e9
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 19 deletions.
diff --git a/sources/commands/Disable.ts b/sources/commands/Disable.ts
@@ -50,18 +50,25 @@ export class DisableCommand extends Command<Context> {
       ? SupportedPackageManagerSetWithoutNpm
       : this.names;
 
+    const binNamesMap = new Map<string, Set<string>>();
+
     for (const name of new Set(names)) {
       if (!isSupportedPackageManager(name))
         throw new UsageError(`Invalid package manager name '${name}'`);
 
-      for (const binName of this.context.engine.getBinariesFor(name)) {
-        if (process.platform === `win32`) {
-          await this.removeWin32Link(installDirectory, binName);
-        } else {
-          await this.removePosixLink(installDirectory, binName);
-        }
-      }
+      const binNames = this.context.engine.getBinariesFor(name);
+      binNamesMap.set(name, binNames);
     }
+
+    const allBinNames = Array.from(binNamesMap.values()).flatMap(binNames => Array.from(binNames));
+
+    await Promise.all(allBinNames.map(binName => {
+      if (process.platform === `win32`) {
+        return this.removeWin32Link(installDirectory, binName);
+      } else {
+        return this.removePosixLink(installDirectory, binName);
+      }
+    }));
   }
 
   async removePosixLink(installDirectory: string, binName: string) {

diff --git a/sources/commands/Enable.ts b/sources/commands/Enable.ts
@@ -60,18 +60,25 @@ export class EnableCommand extends Command<Context> {
       ? SupportedPackageManagerSetWithoutNpm
       : this.names;
 
+    const binNamesMap = new Map<string, Set<string>>();
+
     for (const name of new Set(names)) {
       if (!isSupportedPackageManager(name))
         throw new UsageError(`Invalid package manager name '${name}'`);
 
-      for (const binName of this.context.engine.getBinariesFor(name)) {
-        if (process.platform === `win32`) {
-          await this.generateWin32Link(installDirectory, distFolder, binName);
-        } else {
-          await this.generatePosixLink(installDirectory, distFolder, binName);
-        }
-      }
+      const binNames = this.context.engine.getBinariesFor(name);
+      binNamesMap.set(name, binNames);
     }
+
+    const allBinNames = Array.from(binNamesMap.values()).flatMap(binNames => Array.from(binNames));
+
+    await Promise.all(allBinNames.map(binName => {
+      if (process.platform === `win32`) {
+        return this.generateWin32Link(installDirectory, distFolder, binName);
+      } else {
+        return this.generatePosixLink(installDirectory, distFolder, binName);
+      }
+    }));
   }
 
   async generatePosixLink(installDirectory: string, distFolder: string, binName: string) {

diff --git a/sources/commands/InstallGlobal.ts b/sources/commands/InstallGlobal.ts
@@ -43,13 +43,13 @@ export class InstallGlobalCommand extends BaseCommand {
     if (this.args.length === 0)
       throw new UsageError(`No package managers specified`);
 
-    for (const arg of this.args) {
+    await Promise.all(this.args.map(arg => {
       if (arg.endsWith(`.tgz`)) {
-        await this.installFromTarball(path.resolve(this.context.cwd, arg));
+        return this.installFromTarball(path.resolve(this.context.cwd, arg));
       } else {
-        await this.installFromDescriptor(specUtils.parseSpec(arg, `CLI arguments`, {enforceExactVersion: false}));
+        return this.installFromDescriptor(specUtils.parseSpec(arg, `CLI arguments`, {enforceExactVersion: false}));
       }
-    }
+    }));
   }
 
   log(locator: Locator) {
@@ -86,7 +86,6 @@ export class InstallGlobalCommand extends BaseCommand {
       if (segments.length > 0 && segments[segments.length - 1] !== `.corepack`)
         return;
 
-
       if (segments.length < 3) {
         hasShortEntries = true;
       } else {