Skip to content

Commit

Permalink
chore: adjust tsconfig.json settings (#532)
Browse files Browse the repository at this point in the history
Because Corepack is bundled with esbuild, the correct, recommended tsconfig.json settings are:
- module: preserve
- moduleResolution: bundler

This ensures that modules are resolved the way esbuild resolves them, and opens us to using e.g. package.json exports (which will come in handy in the next PR in which I update tar dependency).
  • Loading branch information
wojtekmaj authored Jul 17, 2024
1 parent 85e556a commit 06e5872
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
"baseUrl": ".",
"esModuleInterop": true,
"experimentalDecorators": true,
"moduleResolution": "node",
"noEmit": true,
"forceConsistentCasingInFileNames": true,
"lib": ["ES2023"],
"module": "commonjs",
"module": "preserve",
"moduleResolution": "bundler",
"noEmit": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
Expand Down

0 comments on commit 06e5872

Please sign in to comment.