Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add test-digitalocean-fedora41-x64-[12] #3964

Merged
merged 3 commits into from
Nov 22, 2024
Merged

ansible: add test-digitalocean-fedora41-x64-[12] #3964

merged 3 commits into from
Nov 22, 2024

Conversation

targos
Copy link
Member

@targos targos commented Nov 19, 2024

Note that I had to manually install an Ansible dependency before running the playbook because of ansible/ansible#84206:

dnf install python3-libdnf5

@targos
Copy link
Member Author

targos commented Nov 19, 2024

@targos targos marked this pull request as ready for review November 19, 2024 19:52
@targos
Copy link
Member Author

targos commented Nov 19, 2024

Build and tests passed.

@richardlau
Copy link
Member

Note that I had to manually install an Ansible dependency before running the playbook because of ansible/ansible#84206:

dnf install python3-libdnf5

Maybe that could be in bootstrap, like the selinux stuff in https://github.com/nodejs/build/blob/main/ansible/roles/bootstrap/tasks/partials/fedora.yml (you'd have to use raw commands instead of the dnf/package module)?

@targos
Copy link
Member Author

targos commented Nov 21, 2024

Maybe that could be in bootstrap, like the selinux stuff in main/ansible/roles/bootstrap/tasks/partials/fedora.yml (you'd have to use raw commands instead of the dnf/package module)?

Done. I setup https://ci.nodejs.org/computer/test-digitalocean-fedora41-x64-2/ with it.

@targos targos changed the title ansible: add test-digitalocean-fedora41-x64-1 ansible: add test-digitalocean-fedora41-x64-[12] Nov 21, 2024
@targos
Copy link
Member Author

targos commented Nov 21, 2024

@targos targos merged commit acfdd94 into main Nov 22, 2024
2 checks passed
@targos targos deleted the fedora41 branch November 22, 2024 06:49
@richardlau
Copy link
Member

FWIW today's node-daily-v18.x-staging run failed on Fedora 41:
https://ci.nodejs.org/job/node-test-commit-linux/61746/nodes=fedora-latest-x64/console

10:00:40 python3 ./configure --verbose 
10:00:40 Please use python3.12 or python3.11 or python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
10:00:40 Node.js configure: Found Python 3.13.0...
10:00:40 make: *** [Makefile:569: build-ci] Error 1

I've cherry-picked nodejs/node@54035ac onto v18.x-staging and kicked off a build (which I expect to pass -- it did when I tried in a local Fedora 41 container with the cherry-pick applied): https://ci.nodejs.org/job/node-test-commit-linux/61748/nodes=fedora-latest-x64/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants