Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make esm treeshake friendly and add test #661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make esm treeshake friendly and add test #661

wants to merge 1 commit into from

Conversation

loynoir
Copy link

@loynoir loynoir commented Mar 21, 2022 •
edited
Loading

This PR

  1. makes js-yaml esm treeshake friendly
  2. new test added
  3. NOT update dist, to get it easier to review
  4. 2+3, leads to CI failure

This PR + updated dist

  1. can be found in branch https://github.com/loynoir/js-yaml/tree/feat-esm-treeshake-friendly-with-dist
  2. tests pass on node10, node12, node 14, node16, node17
  3. fixed esm release tree shake is not pure #631

@alexander-riss
Copy link

@puzrin any opinion on this? it looks like this might help downstream projects cut down on bundle size via tree-shaking

@seravifer
Copy link

Any updates?

@kpollich kpollich mentioned this pull request Dec 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esm release tree shake is not pure
3 participants
@loynoir @alexander-riss @seravifer