Basic prep fix 1 #1801
Merged
Basic prep fix 1 #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using XML Date format instead of Internet Date format for Solid-PREP Notifications.
Swapped the `object` and `target`/`origin` properties in case of `Add`/`Delete` notifications respectively.
+ Notifications are identified by UUIDs. + Turtle notification template has the same fields as JSON-LD. + `notify:state` transmits Event-ID (which uniquely identifies a resource's state) and not E-Tag (which identify representations of the resource). + Parent reuses the generated Event-ID.
+ Event-ID is generated in PREP notification middleware itself. + No longer setting `Event-ID` response header upon resource mutation, thus reverting the middlewares for unsafe methods to their original state, before PREP was introduced.
Change the CI node-version to use caret range to ensure that tests are run on Node.js v20.
Values for `as:object`, `as:target` and `as:origin` predicates in the Turtle PREP-Notification template are IRI's, so they must be wrapped in angle brackets. Co-authored-by: Sarven Capadisli <[email protected]>
|
LGTM |
|
Just waiting for @csarven to check the final commit. |
|
Nothing. @bourgeoa prefers it this way, as it allows him to run CTH with solidcommunity.net when the branch is in the repo. And then he merges that. |
|
Yes but not only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.