fix issue 1774 #1775
Merged
fix issue 1774 #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction to properly render html, updated unit test
…fixed loadUser function
|
I think the message should say the email is sent 'to' the associated account, not from as that doesn't make sense. |
|
Thanks. Done |
TallTed
reviewed
Mar 18, 2024
| @@ -123,7 +123,10 @@ class PasswordResetEmailRequest extends AuthRequest { | |||
| return this.accountManager.accountExists(username) | |||
| .then(exists => { | |||
| if (!exists) { | |||
| throw new Error('Account not found for that username') | |||
| // For security reason avoid leaking error information | |||
There was a problem hiding this comment.
Merged too quickly!
Suggested change
| // For security reason avoid leaking error information | |
| // For security reasons, avoid leaking error information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed account manager error checking, changed loadUser function to properly render html, updated unit test