fix issue 1770: #1773
Closed
fix issue 1770: #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset on nonexistent user: view issue 1770
bourgeoa
requested changes
Mar 15, 2024
|
@zg009 Do you work locally ? if yes you should Usually after a PR it is good practice to come back and look a the tests. Thereafter clear any issue due to your changes. |
|
I saw the test fail, I thought I had passed the linting check but had forgotten to save, so I committed without fixing the formatting issues. Edit: And it is okay, I didn't know you could return a non-Promise value from a Promise after all. Should I also change the comment above resetLinkMessage() since it no longer throws an Error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed error handling of attempting to send password reset on nonexistent user: view issue 1770
@bourgeoa , I wasn't sure what you meant by changing that one line, as I could not find a fix without changing how the accountManager worked downstream, so I simply added an error code check to if request.validate() fails it still passes through the catch.
If you have a better idea let me know and I will change + test