Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit message #1772

Merged
merged 1 commit into from
Mar 16, 2024
Merged

edit message #1772

merged 1 commit into from
Mar 16, 2024

Conversation

bourgeoa
Copy link
Member

No description provided.

@bourgeoa bourgeoa requested a review from zg009 March 15, 2024 09:54
@bourgeoa bourgeoa linked an issue Mar 15, 2024 that may be closed by this pull request
Username leakage from account creation #1771
Closed
zg009
zg009 reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@zg009 zg009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me since you just changed the error code. I'm not sure if the build failing needs to be resolved or not.

@bourgeoa bourgeoa requested a review from zg009 March 15, 2024 21:31
@bourgeoa bourgeoa self-assigned this Mar 15, 2024
@zg009
Copy link
Contributor

zg009 commented Mar 15, 2024

Alain did you need me to review this again, or test it locally?

@bourgeoa
Copy link
Member Author

No I just wanted to see if you were an allowed reviewer.
I ran the tests locally. Only the NSS ones, not the test-suite (solid specification tests)
The test issue is irritating. Around the same location, not always exactly the same and only in CI.
Locally the same test-suite tests pass without any issue.

@bourgeoa bourgeoa merged commit bd171fa into main Mar 16, 2024
1 of 2 checks passed
@bourgeoa bourgeoa deleted the fix/issue#1771 branch March 16, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zg009 zg009 Awaiting requested review from zg009

Assignees

@bourgeoa bourgeoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Username leakage from account creation
2 participants
@bourgeoa @zg009