Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve consistency of the look and feel of the two buttons #1763

Merged
merged 3 commits into from
Apr 22, 2024
Merged

improve consistency of the look and feel of the two buttons #1763

merged 3 commits into from
Apr 22, 2024

Conversation

ewingson
Copy link
Contributor

@ewingson ewingson commented Mar 5, 2024

d2024-03-05 t08:22

@bourgeoa the two buttons look different in the moment in size.
this PR improves the UI via making the size the same and consistent.

@ewingson
Copy link
Contributor Author

ewingson commented Mar 6, 2024 •
edited
Loading

update after code correction:
I'm not sure why the tests fail, the code is exactly as deployed to https://solidweb.org where you can see a working example the buttons look the same now.
would someone with experience take care / feel responsible ?
additional : maybe line 41 should become commented out ?

zg009
zg009 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@zg009 zg009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement to me.

@bourgeoa bourgeoa merged commit 60ef3aa into nodeSolidServer:main Apr 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zg009 zg009 zg009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewingson @zg009 @bourgeoa