Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security issue #1759

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix security issue #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/models/authenticator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ class PasswordAuthenticator extends Authenticator {
})
.then(foundUser => {
if (!foundUser) {
error = new Error('No user found for that username')
// CWE - CWE-200: Exposure of Sensitive Information to an Unauthorized Actor (4.13)
// https://cwe.mitre.org/data/definitions/200.html
error = new Error('Invalid username/password combination.') // no detail for security 'No user found for that username')
error.statusCode = 400
throw error
}
Expand All @@ -151,7 +153,9 @@ class PasswordAuthenticator extends Authenticator {
})
.then(validUser => {
if (!validUser) {
error = new Error('User found but no password match')
// CWE - CWE-200: Exposure of Sensitive Information to an Unauthorized Actor (4.13)
// https://cwe.mitre.org/data/definitions/200.html
error = new Error('Invalid username/password combination.') // no detail for security 'User found but no password match')
error.statusCode = 400
throw error
}
Expand Down
4 changes: 2 additions & 2 deletions test/unit/password-authenticator-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('PasswordAuthenticator', () => {
pwAuth.findValidUser()
.catch(error => {
expect(error.statusCode).to.equal(400)
expect(error.message).to.equal('No user found for that username')
expect(error.message).to.equal('Invalid username/password combination.')
done()
})
})
Expand All @@ -111,7 +111,7 @@ describe('PasswordAuthenticator', () => {
pwAuth.findValidUser()
.catch(error => {
expect(error.statusCode).to.equal(400)
expect(error.message).to.equal('User found but no password match')
expect(error.message).to.equal('Invalid username/password combination.')
done()
})
})
Expand Down
Loading