Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csarven fix/translation error not acceptable #1755

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Csarven fix/translation error not acceptable #1755

merged 3 commits into from
Feb 6, 2024

Conversation

bourgeoa
Copy link
Member

@bourgeoa bourgeoa commented Feb 5, 2024

No description provided.

@bourgeoa bourgeoa self-assigned this Feb 5, 2024
@bourgeoa bourgeoa linked an issue Feb 5, 2024 that may be closed by this pull request
Change translation error (500) to not acceptable (406) #1753
Closed
@bourgeoa bourgeoa mentioned this pull request Feb 5, 2024
Closed
@bourgeoa bourgeoa merged commit 7c8ccc6 into main Feb 6, 2024
1 of 3 checks passed
@michielbdejong
Copy link
Member

Was this PR merged with failing tests? Don't we have a branch protection rule against that?

@bourgeoa
Copy link
Member Author

Was this PR merged with failing tests? Don't we have a branch protection rule against that?

Yes it was.
The CI is quite unstable and prior merging I always do and did the test-suite locally (everything was OK)

@bourgeoa bourgeoa deleted the csarven-fix/translation-error-not-acceptable branch February 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielbdejong michielbdejong michielbdejong approved these changes

@jeff-zucker jeff-zucker Awaiting requested review from jeff-zucker

Assignees

@bourgeoa bourgeoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change translation error (500) to not acceptable (406)
3 participants
@bourgeoa @michielbdejong @csarven