Accept existing xml prefixes to avoid adding to signature #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't Travis use a more recent node version? 0.10 and 0.12 are really old and not supported anymore. |
LoneRifle
requested changes
Feb 7, 2019
LoneRifle
changed the title
|
If I make this work on the old node version, would you accept it? I'm happy to change it then. |
|
I would - and I was planning to make the changes in your branch if not for life getting in the way. Feel free to go ahead of me. |
|
It should be solved now. Thanks for maintaining this library! |
LoneRifle
approved these changes
Feb 25, 2019
markstos
pushed a commit
to node-saml/passport-saml
that referenced
this pull request
Nov 18, 2019
This update will pick up the following changes: node-saml/xml-crypto#171 node-saml/xml-crypto#179 node-saml/xml-crypto#183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way, but it does work.
This adds an extra option
existingPrefixes.I also added this to the README and there is a test.
Fixes #170