Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support use on Node.js 16 #550
fix: support use on Node.js 16 #550
Changes from 1 commit
62d3a95
39bba2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 214 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 218 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
Check failure on line 222 in src/utils.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Replace @ts-ignore with @ts-expect-error
The static analysis tools correctly flag the usage of @ts-ignore. Using @ts-expect-error is preferred as it will error if the type error is fixed, preventing stale suppressions.
📝 Committable suggestion
🧰 Tools
🪛 eslint
[error] 214-214: Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free.
(@typescript-eslint/ban-ts-comment)
[error] 218-218: Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free.
(@typescript-eslint/ban-ts-comment)
[error] 222-222: Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free.
(@typescript-eslint/ban-ts-comment)
🪛 GitHub Check: Node.js / Test (windows-latest, 23)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (windows-latest, 18.19.0)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 23)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18.19.0)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (macos-latest, 23)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (macos-latest, 18.19.0)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
🪛 GitHub Check: Node.js / Test (macos-latest, 20)
[failure] 214-214:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 218-218:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
[failure] 222-222:
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts
Check failure on line 230 in src/utils.ts