Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

feat: support more should.js api #5

Merged
merged 1 commit into from
Apr 13, 2017
Merged

feat: support more should.js api #5

merged 1 commit into from
Apr 13, 2017

Conversation

gxcsoccer
Copy link
Member

#4

  • a.should.have.property(opt)
  • a.should.be.true
  • a.should.length(3)

@mention-bot
Copy link

@gxcsoccer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore to be a potential reviewer.

@codecov
Copy link

codecov bot commented Apr 10, 2017

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           2        2           
  Lines          24       24           
=======================================
  Hits           23       23           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2847c52...6211ac6. Read the comment docs.

@@ -37,5 +37,9 @@ describe('test/xxx.test.js', () => {
obj.should.have.properties('a');
obj.should.have.properties([ 'a', 'b' ]);
obj.should.have.properties({ a: '123', c: false });
obj.should.have.property('a');
obj.should.have.property([ 'a', 'b' ]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个可以去掉,不支持的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gxcsoccer gxcsoccer merged commit 3390166 into master Apr 13, 2017
@gxcsoccer
Copy link
Member Author

1.2.0

@dead-horse dead-horse deleted the support-more-api branch April 13, 2017 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants