test: add node 14.18.0 (#70)

node-modules · Dec 9, 2024 · 58058c5 · 58058c5
1 parent 126f824
commit 58058c5
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 18 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -12,6 +12,6 @@ jobs:
     uses: node-modules/github-actions/.github/workflows/node-test.yml@master
     with:
       os: 'ubuntu-latest, macos-latest, windows-latest'
-      version: '14, 16, 18, 20, 22'
+      version: '14.18.0, 14, 16, 18, 20, 22'
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.gitignore b/.gitignore
@@ -18,3 +18,4 @@ run
 !.gitignore
 !.travis.yml
 *.bin
+package-lock.json
diff --git a/README.md b/README.md
@@ -306,14 +306,8 @@ For more information, you can refer to the [discussion](https://github.com/eggjs
 
 [MIT](LICENSE)
 
-<!-- GITCONTRIBUTOR_START -->
-
 ## Contributors
 
-|[<img src="https://avatars.githubusercontent.com/u/1207064?v=4" width="100px;"/><br/><sub><b>gxcsoccer</b></sub>](https://github.com/gxcsoccer)<br/>|[<img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>|[<img src="https://avatars.githubusercontent.com/u/456108?v=4" width="100px;"/><br/><sub><b>shaoshuai0102</b></sub>](https://github.com/shaoshuai0102)<br/>|[<img src="https://avatars.githubusercontent.com/u/6897780?v=4" width="100px;"/><br/><sub><b>killagu</b></sub>](https://github.com/killagu)<br/>|[<img src="https://avatars.githubusercontent.com/u/32174276?v=4" width="100px;"/><br/><sub><b>semantic-release-bot</b></sub>](https://github.com/semantic-release-bot)<br/>|[<img src="https://avatars.githubusercontent.com/u/227713?v=4" width="100px;"/><br/><sub><b>atian25</b></sub>](https://github.com/atian25)<br/>|
-| :---: | :---: | :---: | :---: | :---: | :---: |
-[<img src="https://avatars.githubusercontent.com/u/546535?v=4" width="100px;"/><br/><sub><b>leoner</b></sub>](https://github.com/leoner)<br/>|[<img src="https://avatars.githubusercontent.com/u/2160731?v=4" width="100px;"/><br/><sub><b>mansonchor</b></sub>](https://github.com/mansonchor)<br/>|[<img src="https://avatars.githubusercontent.com/u/19849579?v=4" width="100px;"/><br/><sub><b>sinkhaha</b></sub>](https://github.com/sinkhaha)<br/>|[<img src="https://avatars.githubusercontent.com/u/6457450?v=4" width="100px;"/><br/><sub><b>limitMe</b></sub>](https://github.com/limitMe)<br/>
-
-This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Tue Jun 20 2023 12:29:14 GMT+0800`.
+[![Contributors](https://contrib.rocks/image?repo=node-modules/cluster-client)](https://github.com/node-modules/cluster-client/graphs/contributors)
 
-<!-- GITCONTRIBUTOR_END -->
+Made with [contributors-img](https://contrib.rocks).
diff --git a/package.json b/package.json
@@ -11,8 +11,7 @@
     "lint": "eslint . --ext .js",
     "test": "npm run lint && npm run test-local",
     "test-local": "egg-bin test",
-    "ci": "egg-bin cov",
-    "contributor": "git-contributor"
+    "ci": "egg-bin cov"
   },
   "repository": {
     "type": "git",
@@ -41,20 +40,20 @@
     "utility": "^2.1.0"
   },
   "devDependencies": {
-    "address": "^1.0.3",
+    "address": "2",
     "await-event": "^2.1.0",
     "coffee": "^5.2.1",
-    "detect-port": "^1.3.0",
+    "detect-port": "2",
     "egg-bin": "^6.4.1",
     "egg-mock": "^5.4.0",
     "eslint": "^8.30.0",
     "eslint-config-egg": "^12.1.0",
-    "git-contributor": "^2.1.5",
     "mm": "^2.4.1",
     "pedding": "^1.1.0",
-    "spy": "^1.0.0"
+    "spy": "^1.0.0",
+    "urllib": "^3.27.1"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=14.18.0"
   }
 }
diff --git a/test/edge_case.test.js b/test/edge_case.test.js
@@ -1,6 +1,6 @@
 const mm = require('mm');
 const assert = require('assert');
-const detect = require('detect-port');
+const { detectPort: detect } = require('detect-port');
 const { sleep } = require('../lib/utils');
 const ApiClient = require('./supports/case_1/api_client');
 

diff --git a/test/index.test.js b/test/index.test.js
@@ -173,6 +173,9 @@ describe('test/index.test.js', () => {
               this.ready(true);
             }
 
+            // async close() {
+            //   this.closed = true;
+            // }
             * close() {
               this.closed = true;
             }
@@ -183,7 +186,7 @@ describe('test/index.test.js', () => {
           // make sure real client is closed;
           // assert has problem with global scope virable
           if (anotherleader[symbols.innerClient]._realClient.closed !== true) {
-            throw new Error();
+            throw new Error('close not work');
           }
         });