(Re -revision)Change the name of the variable name

[noborus]

Change the general name forward for variables.
Add ColumnAttribute and put shink and right align inside.
Added ShrinkColumn and ExpandColumn.

[ccoVeille]

A few suggestions

[ccoVeille]

maybe this ?

Suggested change

	ErrNotAlignMode = errors.New("not align mode")
	ErrNotAlignMode = errors.New("not an align mode")

[noborus]

I see

[ccoVeille]

as the field is private, I would rename it to escapeSequence

Suggested change

	es *escapeSequence
	escapeSequence *escapeSequence

Because no one can guess what es refers to

[noborus]

This is a little hold

[ccoVeille]

Suggested change

	es: newESConverter(),
	escapeSequence: newEscapeSequenceConverter(),

the newESConverter might be renamed to newEscapeSequenceConverter

[ccoVeille]

Based on the fact the default boolean value, this could be written

Suggested change

	columns: []columnAttribute{
	{shrink: false, rightAlign: false},
	{shrink: true, rightAlign: false},
	{shrink: false, rightAlign: false},
	{shrink: false, rightAlign: false},
	{shrink: false, rightAlign: false},
	},
	columns: []columnAttribute{
	{}, {shrink: true}, {}, {}, {},
	},

[ccoVeille]

same logic here

Suggested change

	columns: []columnAttribute{
	{shrink: false, rightAlign: true},
	{shrink: false, rightAlign: false},
	{shrink: false, rightAlign: false},
	{shrink: false, rightAlign: false},
	{shrink: false, rightAlign: false},
	{shrink: true, rightAlign: false},
	},
	columns: []columnAttribute{
	{rightAlign: true}, {}, {}, {}, {}, {shrink: true},
	},

[ccoVeille]

and so on, everywhere

[noborus]

This may also change, but I'll leave it as it is

[ccoVeille]

isn't equivalent to this ?

Suggested change

	for n := len(m.alignConv.columnAttrs); n < len(maxWidths)+1; n++ {
	m.alignConv.columnAttrs = append(m.alignConv.columnAttrs, columnAttribute{})
	}
	m.alignConv.columnAttrs = make([]columnAttribute), len(maxWidths))

[noborus]

This is different. Do not recreate the attributes.I'll add comments.

[ccoVeille]

typo spotted

Suggested change

	// toggleColumnShrink shrinks or expands the current cursor column.
	func (root *Root) toggleColumnShrink(ctx context.Context) {
	cursor := root.Doc.columnCursor
	shrink, err := root.Doc.isColumnShink(cursor)
	if err != nil {
	root.setMessage(err.Error())
	}
	if err := root.Doc.shrinkColumn(cursor, !shrink); err != nil {
	root.setMessage(err.Error())
	}
	}
	// isColumnShink returns whether the specified column is shrink.
	func (m *Document) isColumnShink(cursor int) (bool, error) {
	if m.Converter != convAlign {
	return false, ErrNotAlignMode
	}
	if cursor >= len(m.alignConv.columnAttrs) {
	return false, ErrNoColumnSelected
	}
	return m.alignConv.columnAttrs[cursor].shrink, nil
	}
	// toggleColumnShrink shrinks or expands the current cursor column.
	func (root *Root) toggleColumnShrink(ctx context.Context) {
	cursor := root.Doc.columnCursor
	shrink, err := root.Doc.isColumnShrink(cursor)
	if err != nil {
	root.setMessage(err.Error())
	}
	if err := root.Doc.shrinkColumn(cursor, !shrink); err != nil {
	root.setMessage(err.Error())
	}
	}
	// isColumnShrink returns whether the specified column is shrink.
	func (m *Document) isColumnShrink(cursor int) (bool, error) {
	if m.Converter != convAlign {
	return false, ErrNotAlignMode
	}
	if cursor >= len(m.alignConv.columnAttrs) {
	return false, ErrNoColumnSelected
	}
	return m.alignConv.columnAttrs[cursor].shrink, nil
	}

[noborus]

Oops, thank you!

[ccoVeille]

col starts at 0?

I'm asking because len starts at 1 if there is an element

I'm unsure the code does what is expected

What about this?

 func (a *align) isRightAlign(col int) bool { 

         if c, found := a.columnAttrs[col]; found { 
                  return c.rightAlign
          } 
         return false
  }

[noborus]

yes. col starts from 0.
Need to determine the range because of slice.