-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export metric spec validation rules #536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuklyy
changed the title
export metric spec validation rules
chore: export metric spec validation rules
Sep 10, 2024
kuklyy
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
September 10, 2024 09:23
marcinlawnik
approved these changes
Sep 10, 2024
renovate bot
referenced
this pull request
in nobl9/sloctl
Sep 11, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/nobl9/nobl9-go](https://redirect.github.com/nobl9/nobl9-go) | `v0.84.1-rc3` -> `v0.84.1-rc4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fnobl9%2fnobl9-go/v0.84.1-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fnobl9%2fnobl9-go/v0.84.1-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fnobl9%2fnobl9-go/v0.84.1-rc3/v0.84.1-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fnobl9%2fnobl9-go/v0.84.1-rc3/v0.84.1-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary> ### [`v0.84.1-rc4`](https://redirect.github.com/nobl9/nobl9-go/releases/tag/v0.84.1-rc4) [Compare Source](https://redirect.github.com/nobl9/nobl9-go/compare/v0.84.1-rc3...v0.84.1-rc4) #### What's Changed - chore: Update dependency yaml to v2.5.1 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/532](https://redirect.github.com/nobl9/nobl9-go/pull/532) - chore: Update module golang.org/x/text to v0.18.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/535](https://redirect.github.com/nobl9/nobl9-go/pull/535) - feat: PC-13724 Add custom thresholds for SHR by [@​lukasz-dobek](https://redirect.github.com/lukasz-dobek) in [https://github.com/nobl9/nobl9-go/pull/530](https://redirect.github.com/nobl9/nobl9-go/pull/530) - chore: Update module golang.org/x/tools/cmd/goimports to v0.25.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/540](https://redirect.github.com/nobl9/nobl9-go/pull/540) - chore: export metric spec validation rules by [@​kuklyy](https://redirect.github.com/kuklyy) in [https://github.com/nobl9/nobl9-go/pull/536](https://redirect.github.com/nobl9/nobl9-go/pull/536) **Full Changelog**: nobl9/nobl9-go@v0.84.1-rc3...v0.84.1-rc4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use metric spec validation in other components.
Summary
CountMetricsSpecValidation
andRawMetricsValidation
are now public.Release Notes
CountMetricsSpecValidation
andRawMetricsValidation
are now public.