chore: Switch go-yaml library to Nobl9 fork #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
kskitek
reviewed
Jul 5, 2024
Co-authored-by: kskitek <[email protected]>
kskitek
approved these changes
Jul 6, 2024
nieomylnieja
added a commit
to nobl9/sloctl
that referenced
this pull request
Jul 8, 2024
## Motivation The `replace` clause in `go.mod` was causing `go install` to fail with: ``` go install [github.com/nobl9/sloctl/cmd/sloctl@latest](http://github.com/nobl9/sloctl/cmd/sloctl@latest) go: downloading [github.com/nobl9/sloctl](http://github.com/nobl9/sloctl) v0.3.2 go: [github.com/nobl9/sloctl/cmd/sloctl@latest](http://github.com/nobl9/sloctl/cmd/sloctl@latest) (in [github.com/nobl9/[email protected]](http://github.com/nobl9/[email protected])): The go.mod file for the module providing named packages contains one or more replace directives. It must not contain directives that would cause ``` ## Related changes - nobl9/nobl9-go#482 ## Release Notes Fixed `go install` malfunction introduced in `v0.3.2` caused by `replace` clause in `go.mod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modules using
nobl9-gocannot rely onreplaceclause in the SDK if they are usinggo-yamlpackage as well, in such scenario these modules have to usingreplaceclause too and this in turn breaksgo install, here's an example: