Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct Alert Method type names #476

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

nieomylnieja
Copy link
Collaborator

Motivation

Having sth like v1alpha.Email in the namespace is way too vague, we need more specific naming, that's why we need a prefix.

Copy link
Contributor

@daniel-zelazny daniel-zelazny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nieomylnieja nieomylnieja merged commit f08abc7 into main Jul 1, 2024
5 checks passed
@nieomylnieja nieomylnieja deleted the correct-alert-method-type-names branch July 1, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants