-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PC-13027 PC-13029 Add Azure Monitor managed service for Prometh… #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eus Agent and Metric Spec
Missing LogicMonitor tests
dawidwisn
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
June 3, 2024 14:46
nieomylnieja
requested changes
Jun 4, 2024
nieomylnieja
approved these changes
Jun 6, 2024
lgtm 👌🏻 |
…heus # Conflicts: # go.work.sum
…heus # Conflicts: # go.work.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support new integration with Azure Monitor managed service for Prometheus
Summary
New fields in Agent spec:
azurePrometheus
- name of the new integrationurl
- is theEndpoint - query URL
in Azure Prometheus (How to find the Prometheus URL?)tenentId
- Azure tenent IDNew fields in Metric Spec, example:
azurePrometheus
- name of the new integrationpromql
- a Prometheus query in the PromQL (Prometheus Query Language) that allows the user to select and aggregate time-series data in real-timRelease Notes
Added Azure Monitor managed service for Prometheus Agent, and Metric Spec extending both
v1alpha.Agent.Spec
andv1alpha.SLO.MetricSpec
.