SQL injection protection - enable turn off #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MotwaniM
requested changes
Jul 23, 2024
| @@ -59,3 +59,9 @@ variable "geo_restriction_locations" { | |||
| type = list(string) | |||
| default = ["GB"] | |||
| } | |||
|
|
|||
| variable "sql_injection_protection" { | |||
| description = "Wheather to add SQL injection protection to WAF." | |||
There was a problem hiding this comment.
Spelling issue + would you be okay adding a bit of text to flag that this disables some rules in the WAF that add protection to the overall application. Ok with this is in principle, just want users to be aware of the risks.
MotwaniM
approved these changes
Jul 24, 2024
|
Looks good! We'll merge it as part of our next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrapped up sql injection statement into dynamic block.
The block can be turned off with variable from main rapid module.