Conversation
6 tasks
dissolve_members_column was removed since its purpose was basically the same as old_ids column. unique_key_column parameter was removed and IDs are assumed to be input GDFs index.
Test were adapted to changes introduced by new ID handling and tests specific to the removed dissolve_members_column were removed.
Attributes can now be inherited from feature with most intersecting area with the dissolved geometry, in addition to picking the feature with the minimum id. Inheriting from the feature with most intersecting area is the default option.
JuhoErvasti
force-pushed
the
refactor-buildings
branch
from
777d642 to
af871ac
Compare
rnousia
approved these changes
Jan 9, 2026
choose generic english terms for default values, avoid unnecessary union_all and copy calls
Collaborator
Author
|
@rnousia Ready for another round. |
Collaborator
|
Looking good, good to go! |
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor buildings algorithm to use
BaseAlgorithmand to support identity i.e. dataframe index is used for operations where a separateunique_key_columnwas used previously. Also merged buildings get a hashed index.Includes the commits from #43. Building on the changes there
dissolve_and_inherit_attributescan now inherit attributes from the feature with the most intersection with the dissolved geometry. This is now the default, and the previous "minimum index" behavior is left as an option.Includes some new features for index handling in new modules
identityandsplit. I didn't end up using some of the functions here but I think they'd be useful to have for future use (for instance with watercourse areas).Some small changes had to be made for the 100k test dataset, this was because the aforementioned changes to how attributes are inherited affected which buildings turn to points and which points were reduced. There were 3 affected features in total, and running the refactored algorithm with the original attributes produced the same result, so I believe it was caused purely because of the dissolving changes. I think this is an acceptable change as the new inheritance method seems more logical to use for buildings.
TODO (I think these can be done in a different PR):
classes_for_low_priority_buildingsclasses_for_point_buildingsclasses_for_always_kept_buildingsintorstrwhichtyperdoesn't supportType of change
Bug fix
New feature
Other
Non-breaking change
Breaking change
Developer checklist