Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #3810 #4608

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add regression test for #3810 #4608

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb895ba
:white_check_mark: add regression test for #3810
nlohmann Jan 19, 2025
68c4905
:white_check_mark: add regression test for #3810
nlohmann Jan 22, 2025
2db45cb
:white_check_mark: add regression test for #3810
nlohmann Jan 22, 2025
821d7ef
:white_check_mark: add regression test for #3810
nlohmann Jan 23, 2025
feb18d7
:white_check_mark: add regression test for #3810
nlohmann Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/src/unit-regression2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,17 @@
: for_3333(j.value("x", 0), j.value("y", 0))
{}

/////////////////////////////////////////////////////////////////////
// for #3810
/////////////////////////////////////////////////////////////////////

struct Example_3810
{
int bla{};

Check notice on line 386 in tests/src/unit-regression2.cpp

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

tests/src/unit-regression2.cpp#L386 

struct member 'Example_3810::bla' is never used.
};

NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE(Example_3810, bla);

TEST_CASE("regression tests 2")
{
SECTION("issue #1001 - Fix memory leak during parser callback")
Expand Down Expand Up @@ -1004,6 +1015,23 @@
CHECK(p.x == 1);
CHECK(p.y == 2);
}

SECTION("issue #3810 - ordered_json doesn't support construction from C array of custom type")
{
const Example_3810 states[45]; // NOLINT(cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays)

// This works:
nlohmann::json j;
j["test"] = states;
CHECK(j["test"].dump() == "[{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0}]");

// This doesn't compile:
nlohmann::ordered_json oj;
oj["test"] = states;
CHECK(oj["test"].dump() == "[{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0},{\"bla\":0}]");

CHECK(j["test"].dump() == oj["test"].dump());
nlohmann marked this conversation as resolved.
Show resolved Hide resolved
}
}

DOCTEST_CLANG_SUPPRESS_WARNING_POP
Loading