-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph support #312
Merged
Merged
Add graph support #312
+468
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ae3ee0
to
a83656c
Compare
csbnw
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition to cudawrappers! I did a first pass over the changes and made some (minor) suggestions.
loostrum
reviewed
Jan 24, 2025
wvbbreu
reviewed
Jan 24, 2025
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
dc18c36
to
e122911
Compare
csbnw
reviewed
Feb 5, 2025
csbnw
reviewed
Feb 5, 2025
Co-authored-by: Bram Veenboer <veenboer@astron.nl>
Co-authored-by: Bram Veenboer <veenboer@astron.nl>
Co-authored-by: Bram Veenboer <veenboer@astron.nl>
Co-authored-by: Bram Veenboer <veenboer@astron.nl>
Co-authored-by: Bram Veenboer <veenboer@astron.nl>
c186666
to
28e4dfe
Compare
28e4dfe
to
4770e56
Compare
csbnw
reviewed
Feb 6, 2025
csbnw
reviewed
Feb 6, 2025
csbnw
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA Graph API seems a promising addition to the already existing cuda streams. Especially to mix host and device function in a complex order. Moreover, also HIP supports cuda graphs so it feels natural to extend cudawrappers to supports graph.
In this pull request the basic functionality of cuda graph api are introduced.
Clone and verify on a machine with an NVIDIA GPU
Clone and verify on a machine with HIP and AMD GPU