Add deprecated message to cu::Context #310
Draft
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a deprecated message when instantiating a
cu::Contextinstance. Since contexts are deprecated in HIP, their use should be discouraged.Please note that this pull request will require additional changes, hence it is marked as a draft. For example, the
Context::getTotalMemory()andContext::getFreeMemory()methods are not implemented outside a context scope. We may want to implement these functions outside acu::Context-scope, or hint the user to use an alternative, e.g.,cu::totalMem.In case of the
Context::getLimit()andContext::setLimit()methods; they are not supported in HIP.Related issues:
Instructions to review the pull request