Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Babel preset to @nkzw/babel-preset-fbtee #14

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

alexandernanberg
Copy link
Collaborator

When using the Babel preset using a .babelrc or just when not importing it, e.g.

// .babelrc
{
  "presets": ["@nkzw/babel-fbtee"]
}

Babel throws an error because it's trying to resolve the name to the Babel convention babel-preset-*

Cannot find package '@nkzw/babel-preset-babel-fbtee' imported from ...

A workaround is to add module: like so

// .babelrc
{
  "presets": ["module:@nkzw/babel-fbtee"]
}

but it not super clear and I suspect that people will be confused by it


So I propose we rename the babel preset to follow Babel's expected naming conventions, e.g. @nkzw/babel-preset-fbtee

Copy link
Collaborator

@kayhadrin kayhadrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpojer cpojer merged commit f17fa7e into nkzw-tech:main Dec 20, 2024
1 check passed
@cpojer
Copy link
Collaborator

cpojer commented Dec 20, 2024

Oof, thank you. I wish we had never done string-based module resolution for plugins of babel and eslint…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants