Simplify enum values

nkzw-tech · Dec 17, 2024 · 6b2660e · 6b2660e
1 parent 7364d7a
commit 6b2660e
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 11 deletions.
diff --git a/docs/pronouns.md b/docs/pronouns.md
@@ -18,8 +18,8 @@ const GenderConst = {
   NOT_A_PERSON = 0,
   FEMALE = 1,
   MALE = 2,
-  UNKNOWN_SINGULAR = 7,
-  UNKNOWN_PLURAL = 11,
+  UNKNOWN_SINGULAR = 3,
+  UNKNOWN_PLURAL = 4,
 }
 ```
 
@@ -91,5 +91,5 @@ _Note how `reflexive` and `object` have 4 types_
      0 NOT_A_PERSON          they    their      themself   this
      1 FEMALE                she     her        herself    her
      2 MALE                  he      his        himself    him
-     7 UNKNOWN_SINGULAR      they    their      themself   them
-    11 UNKNOWN_PLURAL        they    their      themselves them
+     3 UNKNOWN_SINGULAR      they    their      themself   them
+     4 UNKNOWN_PLURAL        they    their      themselves them
diff --git a/example/src/example/__tests__/__snapshots__/Example.react-test.tsx.snap b/example/src/example/__tests__/__snapshots__/Example.react-test.tsx.snap
@@ -179,7 +179,7 @@ exports[`Example.react renders the example 1`] = `
                 class="neatoSelect"
               >
                 <option
-                  value="11"
+                  value="4"
                 >
                   Gender:
                 </option>
@@ -189,12 +189,12 @@ exports[`Example.react renders the example 1`] = `
                   Not a person
                 </option>
                 <option
-                  value="11"
+                  value="4"
                 >
                   Unknown (plural)
                 </option>
                 <option
-                  value="7"
+                  value="3"
                 >
                   Unknown (singular)
                 </option>

diff --git a/packages/babel-plugin-fbtee/src/Gender.tsx b/packages/babel-plugin-fbtee/src/Gender.tsx
@@ -14,8 +14,8 @@ export enum GenderConst {
   NOT_A_PERSON = 0,
   FEMALE = 1,
   MALE = 2,
-  UNKNOWN_SINGULAR = 7,
-  UNKNOWN_PLURAL = 11,
+  UNKNOWN_SINGULAR = 3,
+  UNKNOWN_PLURAL = 4,
 }
 
 export const Genders = [

diff --git a/packages/fbtee/ReactTypes.d.ts b/packages/fbtee/ReactTypes.d.ts
@@ -11,6 +11,14 @@ enum IntlVariations {
   GENDER_UNKNOWN = 3,
 }
 
+enum GenderConst {
+  NOT_A_PERSON = 0,
+  FEMALE = 1,
+  MALE = 2,
+  UNKNOWN_SINGULAR = 3,
+  UNKNOWN_PLURAL = 4,
+}
+
 export type ParamOptions = {
   /**
    * `IntlVariations.GENDER_*` Pass the gender of the parameter for correctly variated text.

diff --git a/packages/fbtee/src/GenderConst.tsx b/packages/fbtee/src/GenderConst.tsx
@@ -2,8 +2,8 @@ enum GenderConst {
   NOT_A_PERSON = 0,
   FEMALE = 1,
   MALE = 2,
-  UNKNOWN_SINGULAR = 7,
-  UNKNOWN_PLURAL = 11,
+  UNKNOWN_SINGULAR = 3,
+  UNKNOWN_PLURAL = 4,
 }
 
 export default GenderConst;