Adding more comaprison tests

njoy · Nov 7, 2023 · b07d0c0 · b07d0c0
1 parent 416d056
commit b07d0c0
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/src/tools/ranges/TransformView/Iterator.hpp b/src/tools/ranges/TransformView/Iterator.hpp
@@ -143,24 +143,40 @@ class Iterator {
   friend constexpr bool operator<( const Iterator& left,
                                    const Iterator& right) {
 
+    static_assert(
+      concepts::IsRandomAccessIterator< Iterator >::value == true,
+      "the at() method can only be made available for random access iterators" );
+
     return left.iter_ < right.iter_;
   }
 
   friend constexpr bool operator>( const Iterator& left,
                                    const Iterator& right ) {
 
+    static_assert(
+      concepts::IsRandomAccessIterator< Iterator >::value == true,
+      "the at() method can only be made available for random access iterators" );
+
     return right < left;
   }
 
   friend constexpr bool operator<=( const Iterator& left,
                                     const Iterator& right ) {
 
+    static_assert(
+      concepts::IsRandomAccessIterator< Iterator >::value == true,
+      "the at() method can only be made available for random access iterators" );
+
     return !( right < left );
   }
 
   friend constexpr bool operator>=( const Iterator& left,
                                     const Iterator& right ) {
 
+    static_assert(
+      concepts::IsRandomAccessIterator< Iterator >::value == true,
+      "the at() method can only be made available for random access iterators" );
+
     return !( left < right );
   }
 };
diff --git a/src/tools/ranges/TransformView/Iterator/test/Iterator.test.cpp b/src/tools/ranges/TransformView/Iterator/test/Iterator.test.cpp
@@ -76,6 +76,12 @@ SCENARIO( "TransformView" ) {
         // CHECK( begin == iter );
         // iter = 1 + begin;
         // CHECK( second == iter );
+
+        // the following should not compile: no random access iterator
+        // CHECK( second >= begin );
+        // CHECK( second > begin );
+        // CHECK( begin <= second );
+        // CHECK( begin < second );
       } // THEN
     } // WHEN
   } // GIVEN
@@ -137,6 +143,12 @@ SCENARIO( "TransformView" ) {
         // CHECK( begin == iter );
         // iter = 1 + begin;
         // CHECK( second == iter );
+
+        // the following should not compile: no random access iterator
+        // CHECK( second >= begin );
+        // CHECK( second > begin );
+        // CHECK( begin <= second );
+        // CHECK( begin < second );
       } // THEN
     } // WHEN
   } // GIVEN
@@ -197,6 +209,11 @@ SCENARIO( "TransformView" ) {
         CHECK( begin == iter );
         iter = 1 + begin;
         CHECK( second == iter );
+
+        CHECK( second >= begin );
+        CHECK( second > begin );
+        CHECK( begin <= second );
+        CHECK( begin < second );
       } // THEN
     } // WHEN
   } // GIVEN