Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps tree-sitter Rust dependency to 0.23 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BekaValentine
Copy link

This PR updates the tree-sitter version to 0.23 and makes corresponding changes to the rust bindings to make them uniform with current most up to date grammars for languages like C and C++.

The new lib.rs attempts to reproduce the behavior of @amaanq's corresponding changes elsewhere.

@BekaValentine
Copy link
Author

@cstrahan would it be possible to get approval for the workflow to run on this, and maybe get a review of it?

@scvalex
Copy link

scvalex commented Dec 15, 2024

I've tried this branch and it works for me. The new LANGUAGE member is really nice when interacting with the new tree-sitter-highlight API; without it, you have to add some ugly unsafe casts to get even the most basic functionality working.

@RaitoBezarius
Copy link
Member

@cstrahan Friendly ping.

@bobvanderlinden
Copy link

Maybe @zimbatm as well? The last PR that was merged was by him 😅

@Mic92
Copy link
Member

Mic92 commented Dec 19, 2024

@BekaValentine could you rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants