New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overrides yarl: add build-systems #1430

Merged

adisbladis merged 1 commit into nix-community:master from Kiskae:patch-5

Nov 26, 2023

Contributor

Kiskae commented Nov 25, 2023

yarl moved to their own build backend: aio-libs/yarl@98eac52

The build currently fails if you build the wheel without cython: aio-libs/yarl#962

Contribution checklist (recommended but not always applicable/required):

There's an automated test for this change
Commit messages or code include references to related issues or PRs (including third parties)
Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"


          overrides yarl: add build-systems

029de6d

commit: aio-libs/yarl@98eac52

Contributor Author

Kiskae commented Nov 25, 2023

So the maintainer has said that the Cython dependency is properly declared.

It appears that the pipBuildHook that poetry2nix uses does not validate dynamic build dependencies.

adisbladis merged commit add5dfd into nix-community:master

140 checks passed

Kiskae deleted the patch-5 branch

November 26, 2023 22:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet