plugins/fidget: migrate to mkNeovimPlugin #2647
Open
+531
−590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HeitorAugustoLN
commented
Dec 12, 2024
•
HeitorAugustoLN
commented
- Migrated fidget.nvim to mkNeovimPlugin
- Added renames from old options to new ones (with the exception of the submodules, because I didn't find a way to)
- Added new options, etc.
- Updated tests to new format too
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
3 times, most recently
from
ce3e947 to
a37c6e3
Compare
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
5 times, most recently
from
2223c95 to
e433354
Compare
57 tasks
khaneliman
reviewed
Dec 14, 2024
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
2 times, most recently
from
5992d4b to
063fb6b
Compare
khaneliman
reviewed
Dec 17, 2024
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
3 times, most recently
from
2ae72d4 to
1f1f01f
Compare
khaneliman
approved these changes
Dec 17, 2024
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
2 times, most recently
from
c0a0789 to
73c7489
Compare
plugins/by-name/fidget/default.nix
Outdated
Comment on lines
474
to
576
| "pollRate" | ||
| "suppressOnInsert" | ||
| "ignoreDoneAlready" | ||
| "ignoreEmptyMessage" | ||
| "notificationGroup" | ||
| "clearOnDetach" | ||
| "ignore" | ||
| ]; | ||
| progressDisplayOptions = [ | ||
| "renderLimit" | ||
| "doneTtl" | ||
| "doneIcon" | ||
| "doneStyle" | ||
| "progressTtl" | ||
| "progressIcon" | ||
| "progressStyle" | ||
| "groupStyle" | ||
| "iconStyle" | ||
| "priority" | ||
| "skipHistory" | ||
| "formatMessage" | ||
| "formatAnnote" | ||
| "formatGroupName" | ||
| "overrides" | ||
| ]; | ||
| notificationOptions = [ | ||
| "pollRate" | ||
| "filter" | ||
| "historySize" | ||
| "overrideVimNotify" | ||
| "configs" | ||
| "redirect" | ||
| ]; | ||
| notificationViewOptions = [ | ||
| "stackUpwards" | ||
| "iconSeparator" | ||
| "groupSeparator" | ||
| "groupSeparatorHl" | ||
| ]; | ||
| notificationWindowOptions = [ | ||
| "normalHl" | ||
| "winblend" | ||
| "border" | ||
| "borderHl" | ||
| "zindex" | ||
| "maxWidth" | ||
| "maxHeight" | ||
| "xPadding" | ||
| "yPadding" | ||
| "align" | ||
| "relative" | ||
| ]; | ||
| in | ||
| [ | ||
| [ | ||
| "progress" | ||
| "lsp" | ||
| "progressRingbufSize" | ||
| ] | ||
| [ | ||
| "integration" | ||
| "nvim-tree" | ||
| "enable" | ||
| ] | ||
| [ | ||
| "logger" | ||
| "level" | ||
| ] | ||
| [ | ||
| "logger" | ||
| "floatPrecision" | ||
| ] | ||
| [ | ||
| "logger" | ||
| "path" | ||
| ] | ||
| ] | ||
| ++ (map (oldOption: [ | ||
| "progress" | ||
| oldOption | ||
| ]) progressOptions) | ||
| ++ (map (oldOption: [ | ||
| "progress" | ||
| "display" | ||
| oldOption | ||
| ]) progressDisplayOptions) | ||
| ++ (map (oldOption: [ | ||
| "notification" | ||
| oldOption | ||
| ]) notificationOptions) | ||
| ++ (map (oldOption: [ | ||
| "notification" | ||
| "view" | ||
| oldOption | ||
| ]) notificationViewOptions) | ||
| ++ (map (oldOption: [ | ||
| "notification" | ||
| "window" | ||
| oldOption | ||
| ]) notificationWindowOptions); |
There was a problem hiding this comment.
It'd be nice for this to also be in deprecations.nix.
Perhaps we could restructure that file, so that instead of being a module it is an attrset with optionsRenamedToSettings and imports that can then be used in this file?
There was a problem hiding this comment.
I implemented it, don't know if I did the right way though
There was a problem hiding this comment.
I think it is good now
plugins/by-name/fidget/default.nix
Outdated
Comment on lines
554
to
557
| ++ (map (oldOption: [ | ||
| "progress" | ||
| oldOption | ||
| ]) progressOptions) |
There was a problem hiding this comment.
Note: these outer parens are not needed in concatenation. Also, the new nixfmt rules should allow the list to be on one line, because it is being applied as a function-arg:
Suggested change
| ++ (map (oldOption: [ | |
| "progress" | |
| oldOption | |
| ]) progressOptions) | |
| ++ map (oldOption: [ "progress" oldOption ]) progressOptions |
There was a problem hiding this comment.
I guess the current package version is not up-to-date
There was a problem hiding this comment.
Nixfmt is definitely up to date. Could just be the line ends up being too long, so the formatter insists on having a multiline list.
Comment on lines
+10
to
+16
| mkRemovedOptionModule | ||
| [ | ||
| "plugins" | ||
| "fidget" | ||
| oldOption | ||
| ] | ||
| '' |
There was a problem hiding this comment.
Not 100% sure, but I think the new nixfmt rules allow us to use:
Suggested change
| mkRemovedOptionModule | |
| [ | |
| "plugins" | |
| "fidget" | |
| oldOption | |
| ] | |
| '' | |
| mkRemovedOptionModule [ "plugins" "fidget" oldOption ] '' |
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
3 times, most recently
from
d39848c to
e6db071
Compare
HeitorAugustoLN
force-pushed
the
fidget-migrate
branch
from
e6db071 to
8e5c1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.