modules/nixos/common: reboot on panic #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zowoq
changed the title
Mic92
reviewed
Jan 22, 2025
modules/nixos/common/default.nix
Outdated
| boot.kernel.sysctl = { | ||
| "kernel.hardlockup_panic" = 1; | ||
| "kernel.hung_task_panic" = 1; | ||
| "kernel.panic_on_oops" = 1; |
There was a problem hiding this comment.
When are those applied in the boot process? I would probably apply those late in the boot process (maybe even 5mins after boot) as it can potentially make it hard to debug early boot issues i.e. faulty hardware + kvm console. Those issues would also likely cause a reboot loop anyway.
There was a problem hiding this comment.
Good point, moved to run 5m after boot.
Mic92
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to avoid having stuck machines that need to have their power cycled manually.