Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/nixos/buildbot: add pullBased repo microvm.nix #1598

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

modules/nixos/buildbot: add pullBased repo microvm.nix #1598

wants to merge 3 commits into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 7, 2024 •
edited
Loading

Didn't start automatically so I triggered an eval manually:

warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
warning: ignoring untrusted substituter 'https://microvm.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'
error: worker error: error: flake 'git+file:///var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build' does not provide attribute 'checks'

$ sudo cat /var/lib/buildbot-worker/worker-081/astro_microvm_nix_nix-eval/build/buildbot-nix.toml
attribute = "hydraJobs"

qowoz/microvm.nix@4843601

  • seems to ignore buildbot-nix.toml, works after the flake is changed to checks seems to have been fixed in buildbot-nix

  • eval uses a massive amount of memory

zowoq
zowoq commented Dec 19, 2024
View reviewed changes
modules/nixos/buildbot.nix
Comment on lines +31 to +34
"astro/microvm.nix" = {
url = "https://github.com/qowoz/microvm.nix.git";
defaultBranch = "main";
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"astro/microvm.nix" = {
url = "https://github.com/qowoz/microvm.nix.git";
defaultBranch = "main";
};
"astro/microvm.nix" = {
url = "https://github.com/qowoz/microvm.nix.git";
defaultBranch = "main";
evalWorkerCount = 4;
};

@Mic92 Could we make evalWorkerCount configurable per repo? This repo uses a lot of memory and I really don't want to have to reduce it just for one repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zowoq sounds doable and useful. Please open an issue. We have most of the code needed for this to happen already there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it was easy to add it as a config file option so for now I'll use that: nix-community/buildbot-nix@2d039c3

Unfortunately found other problems. Even with just 8 workers it still uses a lot of memory, too much considering that we other jobs running. Also very slow to eval, after 20 minutes it hasn't even finished aarch64-linux, it'll block jobs other repos. Not sure if we'd want change the current eval lock to something like a per repo eval lock and limit the buildbot instance to 2 concurrent evals.

Copy link
Member

@Mic92 Mic92 Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many virtual machines does this have?
@astro are you sharing nixpkgs instances in your microvm machines tests. Do you disable documentation? Are you applying many overlays?
Maybe we also need to make configurable what it evaluates i.e. only a single architecture.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can easily get the test matrix above 128 tests. It's all individual flake check entries but the nixpkgs are pinned through flake.lock. microvm.nix overlay only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperfine -r 5 'nix-eval-jobs --workers 1 --force-recurse --flake github:astro/microvm.nix#hydraJobs.x86_64-linux.crosvm-startup-shutdown'

Benchmark 1: nix-eval-jobs --workers 1 --force-recurse --flake github:astro/microvm.nix#hydraJobs.x86_64-linux.crosvm-startup-shutdown
  Time (mean ± σ):     91.982 s ±  0.193 s    [User: 54.372 s, System: 25.974 s]
  Range (min … max):   91.669 s … 92.138 s    5 runs

hyperfine -r 5 'nix-eval-jobs --workers 1 --force-recurse --flake github:astro/microvm.nix#hydraJobs.aarch64-linux.qemu-9pstore-overlay-shutdown-command'

Benchmark 1: nix-eval-jobs --workers 1 --force-recurse --flake github:astro/microvm.nix#hydraJobs.aarch64-linux.qemu-9pstore-overlay-shutdown-command
  Time (mean ± σ):     92.361 s ±  0.502 s    [User: 54.808 s, System: 26.118 s]
  Range (min … max):   91.557 s … 92.925 s    5 runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astro astro astro left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zowoq @astro @Mic92